Hide SPA OIDC Providers from JSF login screen #11922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FY26 Sprint 1
github-actions
bot
added
Original size: 10
Size: 10
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/edu/harvard/iq/dataverse/authorization/AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/oidc/OIDCAuthProvider.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/edu/harvard/iq/dataverse/authorization/AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...arvard/iq/dataverse/authorization/providers/oauth2/AbstractOAuth2AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...arvard/iq/dataverse/authorization/providers/oauth2/AbstractOAuth2AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...arvard/iq/dataverse/authorization/providers/oauth2/AbstractOAuth2AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...arvard/iq/dataverse/authorization/providers/oauth2/AbstractOAuth2AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
qqmyers
approved these changes
Jan 21, 2026
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good. This makes the new MPConfig settings the only way to configure an SPA-only provider. Per the discussion - further changes might be needed if/when the JSF is dropped, or the SPA needs more than one provider, or there are more UIs, etc.
I'm leaving a comment about the doc wording but won't hold up approval for it.
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
qqmyers
reviewed
Jan 21, 2026
|
|
||
| For Dataverse instances deploying both the current JSF UI and the new SPA UI, this fix allows the OIDC Keycloak provider configured for the SPA to be hidden in the JSF UI (useful in cases where it would duplicate other configured providers). | ||
|
|
||
| Note: The API to create a new Auth Provider can only be used to create a provider for both JSF and SPA. Use JVM / MicroProfile config setting to create SPA only providers. |
Member
There was a problem hiding this comment.
Something like: Note: If you are using the old and new Dataverse UIs, you must use JVM/MPConfig to create the SPA provider if the old UI will continue using other providers (registered via the API).
qqmyers
reviewed
Jan 21, 2026
|
|
||
| POST http://$SERVER/api/admin/authenticationProviders | ||
|
|
||
| .. note:: This endpoint will create providers for both JSF and SPA. Use :ref:`jvm-options` / *MicroProfile Config* if you need to create SPA only providers. |
Member
There was a problem hiding this comment.
If you use this API to add an OIDC provider for use with the new (SPA) Dataverse UI, it will also be visible in the old (JSF) UI. To avoid this, use the :ref:jvm-options / MicroProfile Config to create an SPA-only provider.
Contributor
|
Tested this with and without additional auth providers configured. The login works as expected from both JSF and SPA. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Some OIDC providers created for SPA fail when selected in JSF UI login screen. These need to only show in the SPA login screen.
Which issue(s) this PR closes: #11606
Special notes for your reviewer:
Suggestions on how to test this: See AdminIT for setup.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: included
Additional documentation: