Do not allow spaces in atom and property names #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiCheng45
approved these changes
Jan 21, 2026
Collaborator
ChiCheng45
left a comment
ChiCheng45
left a comment
There was a problem hiding this comment.
Looks good, works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The atom property editor will not allow the users to input an atom name or atom property containing spaces.
closes #1100
While the original issue was dealing with problems caused by names beginning or ending with a whitespace, this PR proposed to remove whitespaces from names altogether, which has been the convention for all the names in the atom database anyway.
Note: the changes here prevent the user from adding invalid entries through the GUI, and did nothing to prevent it from being done using a script.
Fixes
GeneralWidgets.To test
Try to add/copy/rename atoms and properties using the GUI editor. It should not be possible to use an empty string or a string containing spaces.