Skip to content

Improve QVectorsWidget warning highlighting#1202

Merged
MBartkowiakSTFC merged 2 commits intoprotosfrom
fix-widget-warnings
Mar 26, 2026
Merged

Improve QVectorsWidget warning highlighting#1202
MBartkowiakSTFC merged 2 commits intoprotosfrom
fix-widget-warnings

Conversation

@MBartkowiakSTFC
Copy link
Copy Markdown
Collaborator

Description of work
QVectorsWidget has an extra feature of setting and clearing errors if the inputs in the vector parameter table are invalid. This needed to be updated to account for the possibility of a warning being set in the underlying configurator.

closes #1201

Fixes

  1. Reset the warning after clearing the input errors in the widget.

To test
Try to reproduce the problem from the issue. The warning should stay marked in the GUI.

Copy link
Copy Markdown
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better but there is still the issue where the highlighting can get cleared when you change some other option e.g. weights.

Image

@MBartkowiakSTFC
Copy link
Copy Markdown
Collaborator Author

Its better but there is still the issue where the highlighting can get cleared when you change some other option e.g. weights.

Thanks for catching this one. I'll check if I can fix it too.

@MBartkowiakSTFC
Copy link
Copy Markdown
Collaborator Author

I think this should work now.

@ChiCheng45
Copy link
Copy Markdown
Collaborator

ChiCheng45 commented Mar 26, 2026

One last thing.

image

The run button is disabled, which is right, but highlighted yellow. It's fine, but usually it's not highlighted yellow when other configurators are in an error state. Happy to approve if you think its ok.

image

@MBartkowiakSTFC
Copy link
Copy Markdown
Collaborator Author

The RUN! button should be yellow whenever we have a warning in any of the widgets. It should be disabled when we have a widget with an error. So far, so good.

The q vectors widget creates a warning if one or more of the q-vector shells are empty, and an error if they are all empty. So, it is not possible for it to trigger this specific error without triggering this warning as well. I checked that invalid inputs in the parameter table trigger an error without a warning.

So, I think it's OK.

Copy link
Copy Markdown
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 7d8ea0d into protos Mar 26, 2026
36 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the fix-widget-warnings branch March 26, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] q-vector generator widget warning highlight.

2 participants