Improve QVectorsWidget warning highlighting#1202
Merged
MBartkowiakSTFC merged 2 commits intoprotosfrom Mar 26, 2026
Merged
Conversation
ChiCheng45
reviewed
Mar 25, 2026
Collaborator
Author
Thanks for catching this one. I'll check if I can fix it too. |
Collaborator
Author
|
I think this should work now. |
Collaborator
Collaborator
Author
|
The RUN! button should be yellow whenever we have a warning in any of the widgets. It should be disabled when we have a widget with an error. So far, so good. The q vectors widget creates a warning if one or more of the q-vector shells are empty, and an error if they are all empty. So, it is not possible for it to trigger this specific error without triggering this warning as well. I checked that invalid inputs in the parameter table trigger an error without a warning. So, I think it's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of work
QVectorsWidgethas an extra feature of setting and clearing errors if the inputs in the vector parameter table are invalid. This needed to be updated to account for the possibility of a warning being set in the underlying configurator.closes #1201
Fixes
To test
Try to reproduce the problem from the issue. The warning should stay marked in the GUI.