Skip to content

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Oct 1, 2025

Skip broken acoth. Previously they were marked as broken, but sometimes they randomly pass so better to skip.

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.00%. Comparing base (1a474f5) to head (cbe5890).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          37       37           
  Lines        2029     2029           
=======================================
  Hits         1461     1461           
  Misses        568      568           
Flag Coverage Δ
docs 7.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title [WIP] Fix acoth tests Skip broken acoth tests Oct 1, 2025
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/test_factorizations.jl b/test/test_factorizations.jl
index e9d9dc3..dfbb09a 100644
--- a/test/test_factorizations.jl
+++ b/test/test_factorizations.jl
@@ -55,10 +55,10 @@ using Test: @inferred, @test, @test_throws, @testset
     for f in MATRIX_FUNCTIONS_LOW_ACCURACY
       @eval begin
         fa = $f($a)
-        # `acoth` appears to be broken on this matrix on Windows and Ubuntu
-        # for real matrices.
-        skip = !Sys.isapple() && ($elt <: Real)
-        @test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) skip = skip
+                # `acoth` appears to be broken on this matrix on Windows and Ubuntu
+                # for real matrices.
+                skip = !Sys.isapple() && ($elt <: Real)
+                @test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) skip = skip
         @test fa isa BlockSparseMatrix
         @test issetequal(eachblockstoredindex(fa), [Block(1, 1), Block(2, 2)])
       end

@mtfishman mtfishman merged commit 6d7085d into main Oct 1, 2025
20 checks passed
@mtfishman mtfishman deleted the mf/fixed_acoth_tests branch October 1, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant