-
Notifications
You must be signed in to change notification settings - Fork 2
Add truncerr
truncation strategy
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 0.00% 94.41% +94.41%
==========================================
Files 12 14 +2
Lines 386 412 +26
==========================================
+ Hits 0 389 +389
+ Misses 386 23 -363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@lkdvos it is pretty simple but I'm curious to hear your thoughts on the design. I figure something like this could go in MatrixAlgebraKit.jl but we could try it out here first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks good to me. Any idea why codecov seems to be indicating that findtruncated
is not covered? Just looking at the tests, that shouldn't be the case right?
Hmm good question, I've basically just started ignoring the codecov comments since it seems random to me. If you check the coverage on the codecov website (https://app.codecov.io/gh/ITensor/TensorAlgebra.jl/pull/59) it says they are covered so maybe the comments are outdated. I think maybe what happens is that the codecov comments get posted before the tests finish running so they give false negatives, maybe there is a way to fix that... |
This adds a new MatrixAlgebraKit.jl truncation strategy to minimize the rank without the error in the factorization going above a certain threshold.
Related to https://github.com/Jutho/TensorKit.jl/blob/v0.14.5/src/tensors/truncation.jl and https://github.com/ITensor/ITensors.jl/blob/v0.9.2/NDTensors/src/lib/RankFactorization/src/truncate_spectrum.jl.