Skip to content

Add missing trunc arguments to eigen functions #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025
Merged

Add missing trunc arguments to eigen functions #65

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77bde3d
Add missing trunc arguments
lkdvos Jun 17, 2025
59c6ff8
Apply code suggestion
lkdvos Jun 17, 2025
bf183c0
Bump version
lkdvos Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/MatrixAlgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,19 @@ for (eigen, eigh_full, eig_full, eigh_trunc, eig_trunc) in (
@eval begin
function $eigen(A::AbstractMatrix; trunc=nothing, ishermitian=nothing, kwargs...)
ishermitian = @something ishermitian LinearAlgebra.ishermitian(A)
f = if !isnothing(trunc)
ishermitian ? $eigh_trunc : $eig_trunc
return if !isnothing(trunc)
if ishermitian
$eigh_trunc(A; trunc, kwargs...)
else
$eig_trunc(A; trunc, kwargs...)
end
else
ishermitian ? $eigh_full : $eig_full
if ishermitian(trunc)
$eigh_full(A; kwargs...)
else
$eig_full(A; kwargs...)
end
end
return f(A; kwargs...)
end
end
end
Expand Down
Loading