Fix configure.ac #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On arch linux, this project did not compile due to
CC libpal_la-palDfltin.lo
palDfltin.c: In function 'palDfltin':
palDfltin.c:185:3: error: implicit declaration of function 'strlcpy'; did you mean 'strncpy'? [-Wimplicit-function-declaration]
185 | strlcpy( tempbuf, &(string[*nstrt-1]), sizeof(tempbuf) );
| ^~~~~~~
| strncpy
After some debugging, the issue seems that HAVE_BSD_STRING_H was never set and thus the include never happens.
|
Just an FYI that we don't use this repo anymore. You should use upstream https://github.com/Starlink/pal |
|
Rgr, I will check if the issues also exist on the upstream PAL and open pull requests there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arch linux, this project did not compile due to
CC libpal_la-palDfltin.lo
palDfltin.c: In function 'palDfltin':
palDfltin.c:185:3: error: implicit declaration of function 'strlcpy'; did you mean 'strncpy'? [-Wimplicit-function-declaration]
185 | strlcpy( tempbuf, &(string[*nstrt-1]), sizeof(tempbuf) );
| ^~~~~~~
| strncpy
After some debugging, the issue seems that HAVE_BSD_STRING_H was never set and thus the include never happens.