Dynamically calculate relative path in GifBuilder #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #83 . In Composer-based installations, the
vardirectory is located one level above thepublicfolder, whereas in classic installations it resides withinpublic. Currently, the extension usesEnvironment::getVarPath()to get an absolute path, which causes TYPO3’s core to prepend the public path. This results in an incorrect file path like:To resolve this, I modified the
fileName()method inImaging/GifBuilder.phpto dynamically calculate the relative path from thepublicdirectory to thevardirectory. The approach works as follows:public, the code simply strips the public part from the absolute var path.public(typical for Composer installations), it calculates the number of directory levels to go up (../) and appends the remaining var path.This change ensures that Filefill works correctly across all TYPO3 installations and versions by providing a correct relative path for the GIF builder output. Please review the changes and let me know if further adjustments are needed.