Add a step for syncing README.md to Docker Hub in container-image.yml
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
sync-image-readme-md
branch
3 times, most recently
from
6454960 to
907df68
Compare
yhabteab
changed the title
container-image.yml
yhabteab
force-pushed
the
sync-image-readme-md
branch
from
907df68 to
c3615ec
Compare
julianbrost
reviewed
Aug 8, 2025
|
|
||
| # Check if the README file has been modified since the github.event.before reference point | ||
| # and write the result to the README_MODIFIED ENV variable. | ||
| if git diff --quite --exit-code ${{ github.event.before }} "${{ env.README_FILEPATH }}"; then |
There was a problem hiding this comment.
Suggested change
| if git diff --quite --exit-code ${{ github.event.before }} "${{ env.README_FILEPATH }}"; then | |
| if git diff --quiet --exit-code ${{ github.event.before }} "${{ env.README_FILEPATH }}"; then |
Also, aren't the cases the wrong way around? Exit code 0 (i.e. true) means no difference.
|
Other idea (originating from Icinga/icinga2#10505 (comment)): The documentation mostly describes the |
yhabteab
force-pushed
the
sync-image-readme-md
branch
from
c3615ec to
cadb12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
https://hub.docker.com/r/yhabteab/icinga2
https://github.com/yhabteab/icinga2/actions/runs/16750674510/job/47419810645