Skip to content

Improve ContactForm #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2025
Merged

Improve ContactForm #301

merged 11 commits into from
Oct 7, 2025

Conversation

@sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Feb 17, 2025 •
edited
Loading

@sukhwinder33445 sukhwinder33445 self-assigned this Feb 17, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 17, 2025
@sukhwinder33445 sukhwinder33445 marked this pull request as draft February 17, 2025 19:21
@sukhwinder33445 sukhwinder33445 mentioned this pull request Feb 20, 2025
Closed
@sukhwinder33445 sukhwinder33445 marked this pull request as ready for review February 20, 2025 15:07
@sukhwinder33445 sukhwinder33445 force-pushed the improve-contact-form branch 2 times, most recently from 8c775fd to ffe680c Compare February 21, 2025 08:58
@sukhwinder33445 sukhwinder33445 force-pushed the improve-contact-form branch 4 times, most recently from afe1b01 to 65928a3 Compare May 8, 2025 11:48
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg May 9, 2025 09:12
@sukhwinder33445 sukhwinder33445 force-pushed the improve-contact-form branch 3 times, most recently from 15afc4c to c57238f Compare May 15, 2025 11:21
@sukhwinder33445 sukhwinder33445 linked an issue Jul 23, 2025 that may be closed by this pull request
ContactForm: Selected default channel element must be required #74
Closed
@sukhwinder33445 sukhwinder33445 removed the request for review from ncosta-ic July 23, 2025 11:21
nilmerg
nilmerg requested changes Jul 25, 2025
View reviewed changes
@sukhwinder33445 sukhwinder33445 mentioned this pull request Jul 25, 2025
Merged
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg July 29, 2025 11:46
@sukhwinder33445 sukhwinder33445 force-pushed the improve-contact-form branch 2 times, most recently from b765153 to 251fde3 Compare July 29, 2025 12:17
@sukhwinder33445 sukhwinder33445 removed the request for review from nilmerg July 29, 2025 12:21
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg July 29, 2025 12:48
nilmerg
nilmerg requested changes Aug 8, 2025
View reviewed changes
@sukhwinder33445 sukhwinder33445 force-pushed the improve-contact-form branch 2 times, most recently from 16a7cc6 to 9ad0992 Compare August 11, 2025 10:05
@sukhwinder33445 sukhwinder33445 requested review from nilmerg and removed request for nilmerg September 15, 2025 15:41
@sukhwinder33445
Copy link
Contributor Author

sukhwinder33445 commented Oct 1, 2025

TODO: The form is missing the No channel cofigured message.

sukhwinder33445 and others added 11 commits October 7, 2025 10:11
@sukhwinder33445 @nilmerg
ContactForm: Improve labels of form elements
4b3e474
@sukhwinder33445 @nilmerg
ContactForm: Add description to channels fieldset
dd2915c
@sukhwinder33445 @nilmerg
ContactFrom: Add Default channel element as last form element
61d7ed5 
As the element `default_channel_id` is no longer part of the field set `contact`, it must be handled accordingly
@sukhwinder33445 @nilmerg
ContactForm: Make address field of seleted default channel element `r…
a13106a 
…equired`

AvailableChannelType: Make channel a left join relation
@sukhwinder33445 @nilmerg
ContactForm: Add description for user and default_channel element
70643dd
@sukhwinder33445 @nilmerg
ContactForm: Show suggestions while typing in user element
a1f81b7 
ContactControler: Add suggestion action and cleanup code
@sukhwinder33445 @nilmerg
forms.less: Add .description color and margin
6bf39e0
@sukhwinder33445 @nilmerg
ContactsController: Show add channel link if no channel exists
1a45a18 
- ChannelsContoller: Closing the container is sufficient.
@sukhwinder33445 @nilmerg
ContactForm: Use method addCsrfCounterMeasure()
a93dcc8
@nilmerg
ContactsController: Minor adjustments
b6f95e2
@nilmerg
Channel: Drop unused method fetchChannelNames
29cc836
@nilmerg nilmerg force-pushed the improve-contact-form branch from 67a62ec to 29cc836 Compare October 7, 2025 09:25
@nilmerg nilmerg merged commit beb8a21 into main Oct 7, 2025
10 checks passed
@nilmerg nilmerg deleted the improve-contact-form branch October 7, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve contact configuration ContactForm: Selected default channel element must be required

3 participants

@sukhwinder33445 @nilmerg