Skip to content

ObjectSuggestions: Improve column suggestions #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ObjectSuggestions: Improve column suggestions #769

wants to merge 1 commit into from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented May 31, 2023

No description provided.

@nilmerg nilmerg self-assigned this May 31, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 31, 2023
@nilmerg
Copy link
Member Author

nilmerg commented May 31, 2023

Not near of being final yet.

Using ->isOne() to detect candidate relations is far from perfect. It produces too much noise. (e.g. comment.service_state, even worse: it causes service.state to not appear!) There are also some duplicates (e.g. search for user).

A better heuristic to determine important relations is needed. Or some way to flag relations as only being technical, comment.service_state would be one example for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nilmerg nilmerg

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nilmerg