Use NotWritableError for ini config #5404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
pushed a commit
to Icinga/icingadb-web
that referenced
this pull request
Nov 17, 2025
If saving the Redis settings fails due to a write error, the desired configuration file content is now displayed so that the user can deploy it manually (Same behavior as with database configuration). For that a catch block is introduced on the `NotWritableError` that is added to `IniWriter::write()` in Icinga/icingaweb2#5404. Refs Icinga/icingaweb2#5404 Resolves #1269
nilmerg
added
the
affects-upgrades
Member
|
Please add a note to the upgrading documentation |
nilmerg
pushed a commit
to Icinga/icingadb-web
that referenced
this pull request
Nov 19, 2025
If saving the Redis settings fails due to a write error, the desired configuration file content is now displayed so that the user can deploy it manually (Same behavior as with database configuration). For that a catch block is introduced on the `NotWritableError` that is added to `IniWriter::write()` in Icinga/icingaweb2#5404. Refs Icinga/icingaweb2#5404 Resolves #1269 (cherry picked from commit 3c72286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the unused
Zend_Config_Exceptionwith a more appropriateNotWritableErrorinIniWriter::write().Zend_Config_Exceptionwas never caught anywhere in the codebase.NotWritableErrorto better reflect file permission and write issues.@suppression to thefile_put_contents()call so that the method can throwNotWritableErrorinstead of crashing on PHP warnings.