Skip to content

CsrfCounterMeasure: accept Sec-Fetch-Site header, if available, instead of token #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CsrfCounterMeasure: accept Sec-Fetch-Site header, if available, instead of token #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Common/CsrfCounterMeasure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use ipl\Html\Contract\FormElement;
use ipl\Html\FormElement\HiddenElement;

trait CsrfCounterMeasure

Check failure on line 9 in src/Common/CsrfCounterMeasure.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.2 on ubuntu-latest 

Trait ipl\Web\Common\CsrfCounterMeasure is used zero times and is not analysed.

Check failure on line 9 in src/Common/CsrfCounterMeasure.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.3 on ubuntu-latest 

Trait ipl\Web\Common\CsrfCounterMeasure is used zero times and is not analysed.

Check failure on line 9 in src/Common/CsrfCounterMeasure.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.4 on ubuntu-latest 

Trait ipl\Web\Common\CsrfCounterMeasure is used zero times and is not analysed.
{
/**
* Create a form element to countermeasure CSRF attacks
Expand All @@ -26,6 +26,12 @@
'ignore' => true,
'required' => true,
'validators' => ['Callback' => function ($token) use ($uniqueId, $hashAlgo) {
switch ($_SERVER['HTTP_SEC_FETCH_SITE'] ?? '') {
case 'same-origin': // same scheme, host and port
case 'none': // a user-originated operation
return true;
}

if (empty($token) || strpos($token, '|') === false) {
throw new Error('Invalid CSRF token provided');
}
Expand Down
Loading