Skip to content

Conversation

dino8890
Copy link
Contributor

@dino8890 dino8890 commented May 15, 2025

Fixes #988

Description

This PR fixes invalid examples given in the documentation for the contact_person setting, and expands upon the existing description in a minor way.

Not sure how you want CHANGELOG.md to be formatted, but it might be worthwhile since invalid configuration is likely used in production deployments. No tests are needed as this is a documentation change.

Checklist

  • Checked that no other issues or pull requests exist for the same issue/change
  • Added tests covering the new functionality (N/A)
  • Updated documentation OR the change is too minor to be documented
  • Updated CHANGELOG.md OR changes are insignificant

@vladimir-mencl-eresearch
Copy link
Contributor

Looks very reasonable to me @c00kiemon5ter .

@c00kiemon5ter c00kiemon5ter self-requested a review October 4, 2025 14:51
@c00kiemon5ter c00kiemon5ter self-assigned this Oct 4, 2025
@c00kiemon5ter c00kiemon5ter merged commit 1b5ede8 into IdentityPython:master Oct 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

contact_person documentation is incorrect.

3 participants