Open
Conversation
Member
|
I think dependency on filesystem paths can be easily removed. However, do you have support for threads? This library is architected to run on multiple threads interacting with each other, and that's not easy to change. |
Author
|
We enable threads in Emscripten by passing the IIUC, we get threads support in rust by adding |
a7ad6ac to
db8cf1e
Compare
Author
|
I have updated this PR to build with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to build this package for emscripten. Currently it fails with:
Perhaps there is a way to support emscripten VFS?
This PR adds the CI to reproduce the error.