Fix double exp() of logit_scale in create_probabilities#197
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix double exp() of logit_scale
Fix double Jun 1, 2026
exp() of logit_scale in create_probabilities
Member
|
@work4cs your change seems to lead to complete mis-prediction here (the test failure is in classifying the cat as a plant rather than a cat, not in the newly introduced unit test). Any idea why this is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseClassifier.create_probabilities()was callingself.model.logit_scale.exp(), but the BioCLIP pretrained model storeslogit_scalealready as the scale (not its log), so this appliedexp()twice — producing inflated logits and over-confident (potentially overflowing) probabilities.Changes
src/bioclip/predict.py: Remove.exp()fromlogit_scaleincreate_probabilities():Mirrors the identical fix in Imageomics/bioclip#39.
tests/test_predict.py: AddTestCreateProbabilitieswith two unit tests — one asserting the corrected direct-scale behavior, and one confirming the double-exp()path produces a meaningfully different (wrong) result.