feat: Convert UUID handling from Uuid type to String #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rust files: Include SpruceID attribution as they use/wrap isomdl library - Python/Kotlin files: Indicio-only headers as these are original wrapper code - Both use dual licensing (Apache-2.0 OR MIT) with SPDX identifiers - Added license templates for future consistency: - license-template-with-spruceid.txt: For files using SpruceID code - license-template-indicio.txt: For original Indicio code - Properly distinguishes between original and derived work Signed-off-by: Adam Burdett <[email protected]>
- Update lib.rs to remove custom UUID converter and use direct exports - Change MdlPresentationSession constructor to accept String UUID parameter - Update Mdoc.id() method to return String instead of Uuid - Update MDLReaderSessionData to use String for UUID field - Update Python tests to expect SessionError for invalid UUIDs - Change Rust edition from 2024 to 2021 - Remove unused uuid::Uuid import from reader.rs - Apply cargo fmt formatting fixes This change makes UUID handling more straightforward by using String parameters instead of custom type conversion, improving API usability. Signed-off-by: Adam Burdett <[email protected]>
Resolved conflict in rust/src/lib.rs by keeping copyright headers while maintaining UUID-to-String conversion changes. Signed-off-by: Adam Burdett <[email protected]>
TheTreek
requested changes
Nov 19, 2025
Collaborator
TheTreek
left a comment
TheTreek
left a comment
There was a problem hiding this comment.
Let's use UniFFI's updated type converter instead. https://mozilla.github.io/uniffi-rs/0.30/Upgrading.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes UUID handling more straightforward by using String parameters instead of custom type conversion, improving API usability.
This PR replaces the previous one with a clean commit history and proper DCO sign-off.