Repository navigation
chore(release): drop release-as pin so versions follow commits - #311
Merged
Merged
Conversation
Signed-off-by: David Yunta <davidy@inditex.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration change correctly restores commit-based version calculation.
0 open findings
What changed in this PR
Removes the temporary 1.0.0 release pin so Release Please derives future versions from commits after the existing tag.
Changes:
- Removes the
release-asoverride. - Preserves the manifest’s current
1.0.0baseline.
| File | Description |
|---|---|
release-please-config.json |
Removes the fixed release version override. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
"release-as": "1.0.0"fromrelease-please-config.json. The pin was only needed for the first release.v1.0.0has already been tagged (#307), but the pin keeps forcing 1.0.0, so release-please opened another "release 1.0.0" PR (#309, closed). Without the pin, the next version is worked out from the commits sincev1.0.0.Checklist
git commit -S)Additional context
1.0.0, which matches thev1.0.0tag. No commits since that tag have aRelease-As:footer.docs:commits in docs: add key capabilities to the README, home, and About pages #308 and docs: add how-it-works and bring-your-own notifications to the README #310, becausedocsis a visible changelog section.autorelease: pendinglabel. release-please only acts on merged PRs, so the label can be removed to keep things tidy.