feat: Event disconnected#182
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new “account disconnected” priority event surfaced to the user via the same dialog mechanism previously used for “password changed”, and wires the event into MainScreen.
Changes:
- Added new localized strings for the “account disconnected” event title/description across supported locales.
- Generalized the existing password-changed alert into
PriorityEventAlertDialogwith aPriorityEventAlertenum. - Displayed the new disconnected-account priority dialog from
MainScreenusingviewModel.accountsDisconnected.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds default (EN) strings for the disconnected-account alert. |
| app/src/main/res/values-da/strings.xml | Adds Danish strings for the disconnected-account alert. |
| app/src/main/res/values-de/strings.xml | Adds German strings for the disconnected-account alert. |
| app/src/main/res/values-el/strings.xml | Adds Greek strings for the disconnected-account alert. |
| app/src/main/res/values-es/strings.xml | Adds Spanish strings for the disconnected-account alert. |
| app/src/main/res/values-fi/strings.xml | Adds Finnish strings for the disconnected-account alert. |
| app/src/main/res/values-fr/strings.xml | Adds French strings for the disconnected-account alert. |
| app/src/main/res/values-it/strings.xml | Adds Italian strings for the disconnected-account alert. |
| app/src/main/res/values-nb/strings.xml | Adds Norwegian Bokmål strings for the disconnected-account alert. |
| app/src/main/res/values-nl/strings.xml | Adds Dutch strings for the disconnected-account alert. |
| app/src/main/res/values-pl/strings.xml | Adds Polish strings for the disconnected-account alert. |
| app/src/main/res/values-pt/strings.xml | Adds Portuguese strings for the disconnected-account alert. |
| app/src/main/res/values-sv/strings.xml | Adds Swedish strings for the disconnected-account alert. |
| app/src/main/kotlin/com/infomaniak/auth/ui/screen/main/MainScreen.kt | Shows priority-event dialogs for password-changed and account-disconnected using a shared stack dialog. |
| app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/PriorityEventAlertDialog.kt | Introduces the generalized priority-event alert dialog and event enum. |
Comments suppressed due to low confidence (1)
app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/PriorityEventAlertDialog.kt:85
- For
PriorityEventAlert.AccountDisconnected, the dialog still uses password-change button labels/actions (alertDialogReportButton/alertDialogNeutralButton). This makes the UI misleading (e.g., "I understand" triggersremoveAccount) and the confirm action routes into unauthorized-password-change flow. Consider branching the buttons (text + callbacks) based onevent(e.g., a single confirm like "OK"/"Disconnect" for disconnected, and keep "It wasn’t me" only for password-changed).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-event-disconnected # Conflicts: # app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/PasswordChangedDialog.kt # app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/PriorityEventAlertDialog.kt # app/src/main/kotlin/com/infomaniak/auth/ui/dialog/PasswordChangedDialog.kt # app/src/main/kotlin/com/infomaniak/auth/ui/screen/main/MainScreen.kt
Contributor
|
This PR/issue depends on:
|
1 similar comment
Contributor
|
This PR/issue depends on:
|
tevincent
requested changes
May 18, 2026
tevincent
approved these changes
May 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #181