Skip to content

fix: Delete legacy account if we remove the account after a canceled migration#188

Merged
tevincent merged 1 commit into
mainfrom
delete-legacy-account-if-migration-canceled
May 19, 2026
Merged

fix: Delete legacy account if we remove the account after a canceled migration#188
tevincent merged 1 commit into
mainfrom
delete-legacy-account-if-migration-canceled

Conversation

@tevincent
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 14:07
@tevincent tevincent enabled auto-merge May 19, 2026 14:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates account removal to also clean up matching legacy OTP accounts, addressing canceled migration cleanup.

Changes:

  • Imports legacy OTP cleanup helpers into AuthenticatorManager.
  • Deletes a legacy account after removing the corresponding passkey/account entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread multiplatform-lib/src/commonMain/kotlin/internal/managers/AuthenticatorManager.kt Outdated
@tevincent tevincent disabled auto-merge May 19, 2026 14:22
@tevincent tevincent force-pushed the delete-legacy-account-if-migration-canceled branch from a0879b0 to 9c36c84 Compare May 19, 2026 14:24
@tevincent tevincent enabled auto-merge May 19, 2026 14:24
@tevincent tevincent force-pushed the delete-legacy-account-if-migration-canceled branch from 9c36c84 to e36c577 Compare May 19, 2026 14:35
@sonarqubecloud
Copy link
Copy Markdown

@tevincent tevincent merged commit 8f7173b into main May 19, 2026
9 checks passed
@tevincent tevincent deleted the delete-legacy-account-if-migration-canceled branch May 19, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants