Skip to content

chore(ci): replace pull_request_target with pull_request in dependent issue workflows#766

Merged
FabianDevel merged 1 commit into
mainfrom
copilot/fix-issue-with-dialog-button
May 18, 2026
Merged

chore(ci): replace pull_request_target with pull_request in dependent issue workflows#766
FabianDevel merged 1 commit into
mainfrom
copilot/fix-issue-with-dialog-button

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Summary

  • Updated .github/workflows/dependent-issues.yml to use pull_request instead of pull_request_target
  • Updated .github/workflows/auto-author-assign.yml to use pull_request instead of pull_request_target

Mirrors the change made in android-kMail#2903.

Validation

  • Code Review: no issues found
  • CodeQL Security Scan: 0 alerts

… issue workflows

Agent-Logs-Url: https://github.com/Infomaniak/android-core/sessions/2fe00a39-c964-48c0-8798-2ba5e2590898

Co-authored-by: FabianDevel <45429131+FabianDevel@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@FabianDevel FabianDevel marked this pull request as ready for review May 13, 2026 11:39
Copilot AI review requested due to automatic review settings May 13, 2026 11:39
Copilot AI requested a review from FabianDevel May 13, 2026 11:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions triggers to use pull_request instead of pull_request_target for the dependent-issues and auto-author-assign workflows, aligning with the referenced change in android-kMail. The intent is to avoid running workflows in the elevated pull_request_target context.

Changes:

  • Switched .github/workflows/dependent-issues.yml from pull_request_target to pull_request.
  • Switched .github/workflows/auto-author-assign.yml from pull_request_target to pull_request.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/dependent-issues.yml Triggers the dependent-issues status check workflow on pull_request events instead of pull_request_target.
.github/workflows/auto-author-assign.yml Triggers author auto-assignment on pull_request events instead of pull_request_target.
Comments suppressed due to low confidence (1)

.github/workflows/dependent-issues.yml:14

  • Switching from pull_request_target to pull_request means this workflow will run with a read-only GITHUB_TOKEN and no secrets when the PR comes from a fork. Since this job is intended to create/update a PR status check (and the action uses the token for API calls), the run will likely fail or become a no-op for fork-based contributions. Consider adding a job-level if: github.event.pull_request.head.repo.fork == false (or similar) to skip forks, or otherwise handle the reduced permissions explicitly to avoid noisy failures.
  pull_request:
    types:
      - opened
      - edited
      - closed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/auto-author-assign.yml
@FabianDevel FabianDevel enabled auto-merge May 13, 2026 11:43
@FabianDevel FabianDevel merged commit 01a91a0 into main May 18, 2026
14 checks passed
@FabianDevel FabianDevel deleted the copilot/fix-issue-with-dialog-button branch May 18, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants