fix: Fix ktor headers#767
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix/standardize header configuration for Ktor-based HTTP clients by centralizing common header construction in HttpUtils and reusing it from Ktor defaultRequest blocks.
Changes:
- Refactors
HttpUtils.getHeaders()to build headers from a shared map and adds a KtorHeadersBuilder.setHeaders()helper. - Updates Ktor clients (
createHttpClient,TwoFactorAuthImpl) to usesetHeaders()instead of manual header/user-agent setup. - Updates copyright year ranges.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TwoFactorAuth/Back/src/main/kotlin/TwoFactorAuthImpl.kt | Switches Ktor default request header setup to the new HttpUtils.setHeaders() helper. |
| Network/src/main/kotlin/com/infomaniak/core/network/networking/HttpUtils.kt | Introduces Ktor HeadersBuilder.setHeaders() and refactors header generation to a shared map. |
| Network/Ktor/src/main/kotlin/CreateHttpClient.kt | Replaces explicit Ktor accept/contentType + manual headers with setHeaders() in defaultRequest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
approved these changes
May 18, 2026
|
sirambd
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.