fix: Fix content type header#769
Merged
Merged
Conversation
…dd two methods to call headers method at the right place
There was a problem hiding this comment.
Pull request overview
This PR fixes how default HTTP request headers are applied for Ktor clients, ensuring Accept / Content-Type are set using Ktor’s dedicated APIs (instead of custom header keys), which improves content negotiation and response validation consistency across the network layer.
Changes:
- Refactors
HttpUtils.applyDefaultHeadersto setAcceptandContent-Typevia Ktor request builder helpers and standardHttpHeaderskeys. - Updates Ktor
defaultRequest { ... }usage in clients to callapplyDefaultHeaders()directly rather than nesting it underheaders { ... }. - Corrects previously incorrect header names (e.g.,
Accept-type) by using canonical header constants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TwoFactorAuth/Back/src/main/kotlin/TwoFactorAuthImpl.kt | Updates Ktor defaultRequest to apply default headers correctly at the request-builder level. |
| Network/src/main/kotlin/com/infomaniak/core/network/networking/HttpUtils.kt | Refactors default header application to use Ktor APIs and canonical header names (Accept, Content-Type, etc.). |
| Network/Ktor/src/main/kotlin/CreateHttpClient.kt | Updates default Ktor client creation to apply the new default header logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 19, 2026
sirambd
requested changes
May 19, 2026
|
sirambd
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.