feat: Add dialog when replying to "not reply" recipients#2902
Open
solrubado wants to merge 9 commits into
Open
feat: Add dialog when replying to "not reply" recipients#2902solrubado wants to merge 9 commits into
solrubado wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a confirmation dialog when the user tries to reply/reply-all to messages that appear to come from “no-reply” type recipients, along with localized strings and wiring the prompt into the thread UI and action bottom sheets.
Changes:
- Add a new localized warning string (
alertSenderNoReply) across multiple locales. - Introduce a utility (
SharedUtils.hasNoReplyRecipients) to detect “no-reply” recipients and gate reply actions behind a confirmation dialog. - Update reply entry points (thread UI, quick action bar, message/thread action bottom sheets) and adjust navigation helper to optionally accept a
MainActivity.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds base string for the no-reply warning (and minor reordering of an existing title). |
| app/src/main/res/values-da/strings.xml | Adds Danish translation for the no-reply warning. |
| app/src/main/res/values-de/strings.xml | Adds German translation for the no-reply warning. |
| app/src/main/res/values-el/strings.xml | Adds Greek translation for the no-reply warning. |
| app/src/main/res/values-es/strings.xml | Adds Spanish translation for the no-reply warning. |
| app/src/main/res/values-fi/strings.xml | Adds Finnish translation for the no-reply warning. |
| app/src/main/res/values-fr/strings.xml | Adds French translation for the no-reply warning. |
| app/src/main/res/values-it/strings.xml | Adds Italian translation for the no-reply warning. |
| app/src/main/res/values-nb/strings.xml | Adds Norwegian Bokmål translation for the no-reply warning. |
| app/src/main/res/values-nl/strings.xml | Adds Dutch translation for the no-reply warning. |
| app/src/main/res/values-pl/strings.xml | Adds Polish translation for the no-reply warning. |
| app/src/main/res/values-pt/strings.xml | Adds Portuguese translation for the no-reply warning. |
| app/src/main/res/values-sv/strings.xml | Adds Swedish translation for the no-reply warning. |
| app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt | Adds recipient detection helper used to decide whether to show the confirmation dialog. |
| app/src/main/java/com/infomaniak/mail/utils/extensions/NavigationExt.kt | Extends navigation helper to optionally navigate via a provided MainActivity. |
| app/src/main/java/com/infomaniak/mail/utils/extensions/ConfirmationPopupExt.kt | Adds a new replyWithConfirmationPopup helper for the warning dialog. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt | Wires the confirmation dialog into reply actions from the thread UI and quick action bar. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ThreadActionsBottomSheetDialog.kt | Wires the confirmation dialog into reply/reply-all actions from the thread actions bottom sheet. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt | Wires the confirmation dialog into reply/reply-all actions from the message actions bottom sheet. |
| app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt | Adjusts a call site to the updated navigation helper and removes trailing whitespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to reply a message or thread
2d4cce6 to
6a81655
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.