Skip to content

feat: Add dialog when replying to "not reply" recipients#2902

Open
solrubado wants to merge 9 commits into
mainfrom
no-reply-dialog
Open

feat: Add dialog when replying to "not reply" recipients#2902
solrubado wants to merge 9 commits into
mainfrom
no-reply-dialog

Conversation

@solrubado
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 12, 2026 14:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a confirmation dialog when the user tries to reply/reply-all to messages that appear to come from “no-reply” type recipients, along with localized strings and wiring the prompt into the thread UI and action bottom sheets.

Changes:

  • Add a new localized warning string (alertSenderNoReply) across multiple locales.
  • Introduce a utility (SharedUtils.hasNoReplyRecipients) to detect “no-reply” recipients and gate reply actions behind a confirmation dialog.
  • Update reply entry points (thread UI, quick action bar, message/thread action bottom sheets) and adjust navigation helper to optionally accept a MainActivity.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Adds base string for the no-reply warning (and minor reordering of an existing title).
app/src/main/res/values-da/strings.xml Adds Danish translation for the no-reply warning.
app/src/main/res/values-de/strings.xml Adds German translation for the no-reply warning.
app/src/main/res/values-el/strings.xml Adds Greek translation for the no-reply warning.
app/src/main/res/values-es/strings.xml Adds Spanish translation for the no-reply warning.
app/src/main/res/values-fi/strings.xml Adds Finnish translation for the no-reply warning.
app/src/main/res/values-fr/strings.xml Adds French translation for the no-reply warning.
app/src/main/res/values-it/strings.xml Adds Italian translation for the no-reply warning.
app/src/main/res/values-nb/strings.xml Adds Norwegian Bokmål translation for the no-reply warning.
app/src/main/res/values-nl/strings.xml Adds Dutch translation for the no-reply warning.
app/src/main/res/values-pl/strings.xml Adds Polish translation for the no-reply warning.
app/src/main/res/values-pt/strings.xml Adds Portuguese translation for the no-reply warning.
app/src/main/res/values-sv/strings.xml Adds Swedish translation for the no-reply warning.
app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt Adds recipient detection helper used to decide whether to show the confirmation dialog.
app/src/main/java/com/infomaniak/mail/utils/extensions/NavigationExt.kt Extends navigation helper to optionally navigate via a provided MainActivity.
app/src/main/java/com/infomaniak/mail/utils/extensions/ConfirmationPopupExt.kt Adds a new replyWithConfirmationPopup helper for the warning dialog.
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt Wires the confirmation dialog into reply actions from the thread UI and quick action bar.
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ThreadActionsBottomSheetDialog.kt Wires the confirmation dialog into reply/reply-all actions from the thread actions bottom sheet.
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt Wires the confirmation dialog into reply/reply-all actions from the message actions bottom sheet.
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt Adjusts a call site to the updated navigation helper and removes trailing whitespace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Comment thread app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants