Skip to content

BUG: code crashes when DICOM with 12 bits allocated is processed #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: code crashes when DICOM with 12 bits allocated is processed #5561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmRAWCodec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ bool RAWCodec::DecodeBytes(const char* inBytes, size_t inBufferLength,
this->GetPixelFormat() == PixelFormat::INT12 )
{
size_t len = str.size() * 16 / 12;
if (inOutBufferLength != len)
{
gdcmDebugMacro("inOutBufferLength = " << inOutBufferLength
<< ", inBufferLength = " << inBufferLength << ", len = " << len)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; at the end of the line 123.

Also (line 133, 134)

    assert (len == inOutBufferLength);
    gdcm_assert(inOutBufferLength == len);

becаme unreachable, can be deleted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malaterre This issue may be resolved by removing line 133 in the upstream GDCM code. It looks like an assert persists in the code and causes the crash.

Copy link
Member

@issakomi issakomi Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malaterre This issue may be resolved by removing line 133 in the upstream GDCM code. It looks like an assert persists in the code and causes the crash.

gdcm_assert(exception) won't be caught by ITK, even if it were, there would be a memory leak (copy is freed after this)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the builds failed due to Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmRAWCodec.cxx:123:86: error: expected ';' after 'static_assert'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see commit f57e45134ce6f0092687d0c4a69b5d7bee991dc5 in git/release branch. Let me know if this is acceptable solution.

Thanks all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Purushoth24051999 please check malaterre/GDCM@f57e451. To easily do that, download and build this version of GDCM, then in ITK turn on ITK_USE_SYSTEM_GDCM. Then you should be able to pick GDCM_DIR.

Copy link
Member

@issakomi issakomi Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdcm_assert (it throws an exception) is dead code (luckily)

S1

return false;
}
char * copy = new char[len];
bool b = Unpacker12Bits::Unpack(copy, str.data(), str.size() );
if (!b)
Expand Down
Loading