STYLE: Increase code coverage, make intent clear #5562
Merged
+27
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Segmentation
|
The primary purpose for this change is self-serving :). I am using ITK as a talking point in my teaching of how I then noticed that the code coverage exposed code that So I am practicing what I preach to students: Employ So ... my good deed for the day :). |
hjmjohnson
force-pushed
the
improve-code-coverage
branch
from
7d80d9d to
d270b3b
Compare
github-actions
bot
added
the
area:Filtering
SimonRit
reviewed
Oct 17, 2025
dzenanz
requested changes
Oct 17, 2025
blowekamp
reviewed
Oct 17, 2025
Improve code coverage by simplying default code flow paths.
hjmjohnson
force-pushed
the
improve-code-coverage
branch
from
d270b3b to
782a3d9
Compare
hjmjohnson
changed the title
dzenanz
reviewed
Oct 20, 2025
Improved readability and make the intent of searching for clusters more transparent. As a side effect, the code coverage now is at 100% in the default case where clusters are found.
hjmjohnson
force-pushed
the
improve-code-coverage
branch
from
782a3d9 to
ae049cd
Compare
dzenanz
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code coverage by refactoring termination path order.
Improve code intent with explicit variable for determining if a
a cluster is found.
PR Checklist