Skip to content

Replace SetIndex, SetSize and SetSize, SetIndex calls with region = { index, size } assignment #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

Replace SetIndex, SetSize and SetSize, SetIndex calls with region = { index, size } assignment #5563

merged 2 commits into from
Oct 20, 2025
+261 −522

Conversation

@N-Dekker
Copy link
Contributor

Replaced code like:

region.SetIndex(index);
region.SetSize(size);

With the equivalent assignment, region = { index, size };

@N-Dekker
STYLE: Replace SetIndex, SetSize calls with region = { index, size }
cd2a305 
Using Notepad++, Replace in Files:

    Find what: ^( [ ]+\w*[Rr]eg\w*)\.SetIndex\((\w+)\);[\r\n]+\1\.SetSize\((\w+)\);$
    Replace with: $1 = { $2, $3 };

Manually excluded `ioregion` (from itkMetaImageStreamingWriterIOTest.cxx).

Follow-up to pull request InsightSoftwareConsortium#5560
commit 7bf4162
"STYLE: Replace SetIndex, SetSize calls with `region{ index, size }`"
@N-Dekker
STYLE: Replace SetSize, SetIndex calls with region = { index, size }
f8a513d 
Using Notepad++, Replace in Files:

    Find what: ^( [ ]+[^ ].*)\.SetSize\((\w+)\);[\r\n]+\1\.SetIndex\((\w+)\);$
    Replace with: $1 = { $2, $3 };

Follow-up to pull request InsightSoftwareConsortium#5560
commit 3bd355a
"STYLE: Replace SetSize, SetIndex calls with `region{ index, size }`"
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module area:Numerics Issues affecting the Numerics module labels Oct 17, 2025
@N-Dekker N-Dekker marked this pull request as ready for review October 17, 2025 18:50
@N-Dekker N-Dekker requested a review from hjmjohnson October 17, 2025 20:47
@hjmjohnson hjmjohnson merged commit ed83774 into InsightSoftwareConsortium:main Oct 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-Dekker @hjmjohnson @dzenanz