Draft
fix: #752 guard purgeStaleCacheEntries against undefined storage on Node 26#753
Conversation
…ode 26 Co-authored-by: ascott18 <5017521+ascott18@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unguarded purgeStaleCacheEntries call during import
fix: #752 guard purgeStaleCacheEntries against undefined storage on Node 26
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node 26,
localStorageandsessionStorageare defined as globals but resolve toundefinedunless--localstorage-fileis passed. BecausepurgeStaleCacheEntriesis called at module scope with no guard, importingcoalesce-vuethrows aTypeErrorbefore any test runs — breaking every Vitest+jsdom suite on Node 26 that transitively imports the package.Changes
src/coalesce-vue/src/api-client.ts— added an early-return guard topurgeStaleCacheEntries; degrades silently to "nothing to purge" when storage isundefined/nullor not a validStorageobject: