Fix/add site identifier support #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents
Add siteIdentifier value to support multiple Curator sites in the same
namespace. When set, it's included in ExternalSecret and Job secret
reference names to prevent resource conflicts.
Backward compatible: if not set, behavior remains unchanged with
existing {environment}-admin naming pattern.
TyFive
reviewed
Oct 22, 2025
TyFive
approved these changes
Oct 22, 2025
Extract admin secret name logic into curator.adminSecretName helper to improve maintainability and reduce duplication across templates. Regenerate README.md via helm-docs.
kody-iw
force-pushed
the
fix/add-site-identifier-support
branch
from
be9740e to
988ab0e
Compare
henryjarend
approved these changes
Nov 4, 2025
Contributor
henryjarend
left a comment
henryjarend
left a comment
There was a problem hiding this comment.
This should get tested on a dev site probably before it gets merged in. I've done this by pausing the flux helmrelease/kustomization, grabbing my values, then running a helm upgrade and making sure it all works out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
siteIdentifiervalue to support multiple Curator deployments in the same namespaceBackward Compatibility
✅ Fully backward compatible - existing deployments without
siteIdentifiercontinue using{environment}-adminnaming patternUse Case
Enables multi-site deployments in shared namespaces by preventing ExternalSecret name conflicts:
siteIdentifier:prod-admin(existing behavior)siteIdentifier: reports:prod-reports-admin(new capability)