Integration of [Kee et al. 2023]: "An Optimization-Based SPH Solver for Simulation of Hyperelastic Solids"#372
Open
minh702 wants to merge 2 commits intoInteractiveComputerGraphics:masterfrom
Open
Conversation
…L-BFGS; validating line search
…ion, SVD polar decomposition fix - L-BFGS: runtime window size change with buffer renewal; window=0 for constant Hessian - Line search: backtracking Armijo + flat energy termination (|dE| < 1e-4); convergence check before LS - SVD polar decomposition: flip U.col(2) instead of R.col(2) for correct R under inversion - Non-convergence warning at max iterations - Kugelstadt2021: added neighbor list asymmetry check - Beam.json: updated scene config for validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Performance (beam twisting benchmark, ~9K particles, Poisson's ratio = 0.49):
Bug fix:
Fixed an asymmetry issue in neighbor list handling: when the maximum neighbor count is limited (default 15), particle i may include j as a neighbor while j does not include i, causing unbalanced elastic forces and violating momentum conservation. The beam benchmark requires up to 43 neighbors.