Fix frozen particles affected by gravity when using Projective Fluids#373
Open
lukashof wants to merge 1 commit intoInteractiveComputerGraphics:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed frozen particles drifting along the gravity vector instead of being fixed in space. The additional check in
TimeStep::clearAccelerationsensures, gravity is only applied to active particles and fixes the issue.I have only observed the bug using the Projective Fluids scheme, which I find surprising, as the other schemes seem to rely on the function as well. However, that might just be my lack of understanding.
The function name also seems to imply to me that perhaps the accelerations should be set to zero, if the condition is false. But this seemed to make no difference to the result.