Skip to content

Improve ImpTest helpers #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Improve ImpTest helpers #5220

wants to merge 11 commits into from
+252 −302

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Aug 11, 2025 •
edited
Loading

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky changed the base branch from master to ldan/dijkstra-certs August 11, 2025 17:14
@Lucsanszky Lucsanszky changed the base branch from ldan/dijkstra-certs to master August 11, 2025 17:15
@Lucsanszky Lucsanszky mentioned this pull request Aug 27, 2025
Merged
10 tasks
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 4 times, most recently from 2997716 to a5d8109 Compare September 5, 2025 10:17
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch from c7f0287 to 8155e7c Compare September 9, 2025 16:48
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 3 times, most recently from 4dffd56 to 4bbc441 Compare September 17, 2025 22:51
@Lucsanszky Lucsanszky marked this pull request as ready for review September 17, 2025 22:52
@Lucsanszky Lucsanszky requested a review from a team as a code owner September 17, 2025 22:52
@Lucsanszky
Make genRegTxCert a method of ShelleyEraImp
9d9a372
@Lucsanszky
Make genUnRegTxCert a method of ShelleyEraImp
5ad82c8
@Lucsanszky
Remove registerStakeCredentialWithDeposit
fc48f21
@Lucsanszky
Remove registerPoolWithDeposit
6508295
@Lucsanszky
Remove registerRewardAccountWithDeposit
ddee07c
@Lucsanszky
Use certs w/out deposits in some script validation tests
8ab5167 
For some reason, these tests fail if we use certificates with deposits,
so as a temporary measure we will avoid using deposits in these cases.

Related: #4571
@Lucsanszky
Remove shelleyEraSpecificSpec
f9520a1 
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
@Lucsanszky
Remove regDelegToDRep helper
178cb6e 
This reverts commit 9a06817
and related changes.
@Lucsanszky
Move some alonzoEraSpecificSpec tests
67d9120
@Lucsanszky
Remove babbageEraSpecificSpec
b47c91c 
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
@Lucsanszky
Move a conwayEraSpecificSpec testcase
ca9c96d
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch from 4bbc441 to ca9c96d Compare September 17, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lucsanszky