Skip to content

Rename --mainnet option to --params-mainnet #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

Rename --mainnet option to --params-mainnet #6313

merged 1 commit into from
Aug 21, 2025

Conversation

nbacquey
Copy link
Contributor

@nbacquey nbacquey commented Aug 20, 2025 •
edited
Loading

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@nbacquey nbacquey requested a review from a team as a code owner August 20, 2025 14:21
@nbacquey nbacquey requested a review from carbolymer August 20, 2025 14:48
@nbacquey nbacquey changed the title Rename --mainnet option to --mainnet-params Rename --mainnet option to --params-mainnet Aug 20, 2025
carbolymer
carbolymer reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll approve after you confirm that @CarlosLopezDeLara is happy with the change. 😄

CarlosLopezDeLara
CarlosLopezDeLara approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nbacquey nbacquey added this pull request to the merge queue Aug 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 21, 2025
@nbacquey nbacquey added this pull request to the merge queue Aug 21, 2025
Merged via the queue into master with commit 1df3e19 Aug 21, 2025
23 of 24 checks passed
@nbacquey nbacquey deleted the nb/rename_param branch August 21, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer left review comments

@CarlosLopezDeLara CarlosLopezDeLara CarlosLopezDeLara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbacquey @carbolymer @CarlosLopezDeLara