Move non-computational properties to separate submodules #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlostome
reviewed
Sep 29, 2025
There was a problem hiding this comment.
Nice work! I left some comments here and there and some questions.
Maybe the most important ones are about naming/placement of modules:
DepositHelpersis not a property per-se so maybe it shouldn't go in thePropertiesfolderSetoidis too general of a name and there could be many Setoid instances for a type.
src/Ledger/Conway/Specification/Utxo/Properties/Computational.lagda
Outdated
Show resolved
Hide resolved
and fix resulting issues in Ledger.Properties
And make sure Ledger/Properties/Computational.lagda doesn't result in a blank page (without "Show more Agda").
williamdemeo
force-pushed
the
930-move-non-computational-properties
branch
from
1a10851 to
07fe940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes issue #930.
This will make the main computational
Propertiesmodules type-check faster and will make it easier to ignore certain special properties when working on conformance tests.Checklist
CHANGELOG.md