Skip to content

Conversation

jasagredo
Copy link
Contributor

No description provided.

@jasagredo jasagredo changed the base branch from main to js/db-analsyer-one-forker August 22, 2025 14:24
@jasagredo jasagredo force-pushed the js/db-analsyer-one-forker branch from 002b71e to f3e4dac Compare August 22, 2025 14:41
@jasagredo jasagredo requested a review from amesgen August 25, 2025 09:14
@jasagredo jasagredo force-pushed the js/forkers branch 2 times, most recently from 2421e01 to 062bcc8 Compare August 25, 2025 10:57
@jasagredo jasagredo force-pushed the js/db-analsyer-one-forker branch from f3e4dac to 2b121b4 Compare August 25, 2025 11:00
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not in scope for this PR, but the story around safely and correctly releasing resources for forkers is quite complicated (even more so with this PR), with some parts being handled by a ResourceRegistry and some parts by a special StrictTVar m (m ()). I wonder whether we could make some general improvements here; maybe the concept of a temporary registry a la runWithTempRegistry could be used to streamline this?

@jasagredo
Copy link
Contributor Author

jasagredo commented Aug 25, 2025

I plan on merging this as a PR stack:

This is a graph of the dependencies of the PRs:

                 ┌─────┐       
                 │#1603│       
                 └──┬──┘       
                    │          
               ┌────┴─────┐    
            ┌──▼──┐    ┌──▼──┐ 
            │#1572│    │#1647│ 
            └─────┘    └─────┘ 
               │               
   ┌───────┬───┴───┬───────┐   
┌──▼──┐ ┌──▼──┐ ┌──▼──┐ ┌──▼──┐
│#1640│ │#1643│ │#1641│ │#1644│
└─────┘ └─────┘ └─────┘ └─────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants