Skip to content

Conversation

pauljung14
Copy link
Contributor

@pauljung14 pauljung14 commented Sep 9, 2025

JIRA Ticket(s) if any

Description

This PR addresses an issue where in-app message iframes displayed a persistent scrollbar, even when not needed. It also includes a minor cleanup in the example environment file.

Key Changes:

  • In-App Message Iframe Scrollbar Fix (src/inapp/inapp.ts):

    • Modified the throttledResize function to temporarily hide iframe body overflow, set the iframe height to match its content, and then restore the overflow. This prevents the scrollbar from appearing unnecessarily.
    • Adjusted the throttle time for resizing from 750ms to 100ms for more responsive adjustments.
  • react-example/.env.example Cleanup:

    • Removed commented-out lines related to BASE_URL as it's no longer configured via this environment variable in the example application.

Test Steps

Test that scrollbar appearance occurs as expected when resizing browser window. Be sure to include content blocks such as images that would expand in height when width is changed.

@pauljung14 pauljung14 requested a review from mprew97 as a code owner September 9, 2025 15:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.49%. Comparing base (3948ff5) to head (d280687).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   74.35%   74.49%   +0.13%     
==========================================
  Files          57       57              
  Lines        2734     2741       +7     
  Branches      816      820       +4     
==========================================
+ Hits         2033     2042       +9     
+ Misses        700      698       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -6,9 +6,6 @@
# API_KEY=1234
# JWT_SECRET=1234

# Only set BASE_URL if developing locally, as it will take precedence over the production api urls.
# BASE_URL="https://api.iterable.com/api"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the BASE_URL at the root level .env file does anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants