Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 10, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Adds the embedded manager class

Testing

  1. cd into the example dir and run:
    yarn install
    watchman watch-del-all
    yarn start --reset-cache
    ```bash
  2. In a separate terminal, cd into example then either run ios (yarn ios) or android (yarn android)
  3. Click on the "Embedded" tab. You should see the following:
    Does embedded class exist? Yes
    Is embedded manager enabled? Yes
  4. Open example/src/hooks/useIterableApp.tsx
  5. Change config.embeddedMessagingEnabled = true; to config.embeddedMessagingEnabled = false;
  6. Focus on the tab running the server (where you ran yarn start), and hit the key r
  7. The "Embedded" tab should now say:
    Does embedded class exist? Yes
    Is embedded manager enabled? No

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Lines Statements Branches Functions
Coverage: 52%
52.45% (288/549) 27.14% (57/210) 50.49% (102/202)

@qltysh
Copy link

qltysh bot commented Oct 10, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.45%.

File Coverage Changes
Path File Coverage Δ Indirect
src/core/classes/Iterable.ts 0.2
src/embedded/classes/IterableEmbeddedManager.ts 100.0
src/embedded/classes/index.ts 100.0
src/embedded/index.ts 100.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen changed the title feat: add IterableEmbeddedManager class and update exports for embedded messages [MOB-12261] add IterableEmbeddedManager class and update exports for embedded messages Oct 11, 2025
@lposen lposen changed the title [MOB-12261] add IterableEmbeddedManager class and update exports for embedded messages [MOB-12261] Add IterableEmbeddedManager class and update exports for embedded messages Oct 11, 2025
@lposen lposen changed the title [MOB-12261] Add IterableEmbeddedManager class and update exports for embedded messages [MOB-12261] Add IterableEmbeddedManager class Oct 11, 2025
@lposen lposen added the embedded Issues/PRs related to Embedded Messages label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

embedded Issues/PRs related to Embedded Messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants