Support JKA models in OpenJO #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razish
previously approved these changes
Mar 9, 2025
Daggolin
previously approved these changes
May 19, 2025
Member
Daggolin
left a comment
Daggolin
left a comment
There was a problem hiding this comment.
The code is exactly like on jk2mv and a quick test shows it's working. I personally would've preferred to have the additional ifdef as else, because they're mutually exclusive, depending on the target (openjk sp vs. openjo sp), but I am approving this so it can be merged.
Current:
#ifndef JK2_MODE
...
#endif
#ifdef JK2_MODE
...
#endifPeferred:
#ifndef JK2_MODE
...
#else
...
#endifWhen this is merged @SomaZ might have to adapt it for #1179 to keep feature parity for rd-vanilla and rd-rend2.
Contributor
Author
|
I'll make that adjustment when I get home. Thanks for reviewing. |
Daggolin
approved these changes
May 20, 2025
SomaZ
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly ported from mvdevs/jk2mv@ef336f9, mvdevs/jk2mv@3cd7e53, mvdevs/jk2mv@14cb6c9
Tested in-game, appears to work as expected.