Conversation
Replace the outdated mock endpoint in `testStatus404Body` with a new, valid URL. This ensures that the test correctly validates the 404 status response and the corresponding error body, improving test reliability and accuracy.
Change the mock API URL in the testSimple method to use a new endpoint, ensuring the test remains functional. This update is necessary as the previous URL may no longer be available or has been deprecated, and it helps maintain the reliability of our tests.
- Temporarily skip tests using `run.mocky.io` due to their unreliability.
- Update CI workflow:
- Bump PHP version matrix to 8.2, 8.3, 8.4.
- Upgrade `actions/upload-artifact` to v4.
- Add `contents: read` permission and remove scheduled runs.
- Update `composer.json`:
- Increase minimum PHP requirement to 8.2.
- Upgrade `jbzoo/data`, `jbzoo/utils`, `jbzoo/event`, `jbzoo/toolbox-dev`, `rmccue/requests`, and `guzzlehttp/guzzle`.
- Refactor code:
- Adjust type hint order for consistency (`array|string|null`).
- Make `Response` class final and its properties private.
- Add Psalm suppressions for unused classes/return values.
# Conflicts: # tests/AbstractDriverTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run.mocky.iodue to their unreliability.actions/upload-artifactto v4.contents: readpermission and remove scheduled runs.composer.json:jbzoo/data,jbzoo/utils,jbzoo/event,jbzoo/toolbox-dev,rmccue/requests, andguzzlehttp/guzzle.array|string|null).Responseclass final and its properties private.