More flexible fenced code block generation#102
Open
Dansoftowner wants to merge 4 commits intoJPro-one:mainfrom
Open
More flexible fenced code block generation#102Dansoftowner wants to merge 4 commits intoJPro-one:mainfrom
Dansoftowner wants to merge 4 commits intoJPro-one:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes fenced code block rendering more flexible in
jpro-mdfx.Previously,
MDFXNodeHelperalways created aMarkdownCodeBlockdirectly for fenced code blocks. This made it hard for users to customize code block rendering.Changes
MarkdownView.generateFencedCodeBlock(String code, String language).MarkdownCodeBlockdirectly.new MarkdownCodeBlock(code, language)from the default implementation.Why
This allows users to subclass
MarkdownViewand customize fenced code block rendering, similar to the existing customization points for links and images.For example, users can now provide their own code block node, wrap the default
MarkdownCodeBlock, add extra controls, change layout behavior, or apply app-specific behavior while keeping the default MDFX behavior intact.Example
Let's say we want to add a context menu to each code block to give the user the ability to easily copy the particular code to the clipboard:
It's now possible using the standard api.