-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Adds a 'regenerate' button to AI chat tab (#12191) #14191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - We moved all sorting options into a dedicated “Sort” sub-menu in the Groups menu. ([#14017](https://github.com/JabRef/jabref/issues/14017)) | ||
| - We merged `Citation information` and `Citation relations` into a singular tab. [#13618](https://github.com/JabRef/jabref/issues/13618) | ||
| - We changed `ISSNCleanup` into `NormalizeIssn` a `ISSN` formatter. [#13748](https://github.com/JabRef/jabref/issues/13748) | ||
| - We changed Citation Relations tab and gave tab panes more descriptive titles and tooltips. [#13619](https://github.com/JabRef/jabref/issues/13619) | ||
| - We changed the name from Open AI Provider to Open AI (or API compatible). [#13585](https://github.com/JabRef/jabref/issues/13585) | ||
| - We improved the citations relations caching by implementing an offline storage. [#11189](https://github.com/JabRef/jabref/issues/11189) | ||
| - We added a tooltip to keywords that resemble Math Subject Classification (MSC) codes. [#12944](https://github.com/JabRef/jabref/issues/12944) | ||
| - We added a formatter to convert keywords that resemble MSC codes to their descriptions. [#12944](https://github.com/JabRef/jabref/issues/12944) | ||
| - We introduced a new command line application called `jabkit`. [#13012](https://github.com/JabRef/jabref/pull/13012) [#110](https://github.com/JabRef/jabref/issues/110) | ||
| - We added a new "Add JabRef suggested groups" option in the context menu of "All entries". [#12659](https://github.com/JabRef/jabref/issues/12659) | ||
| - We added an option to create entries directly from Bib(La)TeX sources to the 'Create New Entry' tool. [#8808](https://github.com/JabRef/jabref/issues/8808) | ||
| - We added the provision to choose different CSL bibliography body formats (e.g. First Line Indent, Hanging Indent, Bibliography 1, etc.) in the LibreOffice integration. [#13049](https://github.com/JabRef/jabref/issues/13049) | ||
| - We use `https` to connect to [shortDOI](https://shortdoi.org/) service. [#13637](https://github.com/JabRef/jabref/pull/13637) | ||
| - We added "Bibliography Heading" to the available CSL bibliography header formats in the LibreOffice integration. [#13049](https://github.com/JabRef/jabref/issues/13049) | ||
| - We added [LOBID](https://lobid.org/) as an alternative ISBN-Fetcher. [#13076](https://github.com/JabRef/jabref/issues/13076) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are duplicates right? When searching (ctrl+f) for some of those, they can be found in the changelog multiple times. I haven't checked all of them. Commit 7fcba9a seems to have introduced it.
|
Tried this PR. At first worked like expected (regenerating a message multiple times), but when I tried sending a different message right after, it got stuck. See I also got a huge amount of warnings and a few exceptions in the commandline. The chance is high that not all are related to your PR. Here is the Log I captured. When I force closed JabRef, the following exception emerged in the commandline: |
|
Thank you for your review, I did not see this issue at first but I will try to reproduce it and eventually fix it. For now I do not really get why these errors appear, there might be some problem with the onSendMessage method or something like this. Just to be sure (although I don't think it is related), which llm did you use when testing ? |
|
Thanks for looking into it. Maybe you find something in the log. After I sent the review, I restarted JabRef and tried again. Everything went fine. No exceptions. So unfortunately the precise conditions to trigger the exception are still unknown to me. |
|
What app do you use to run the models? |

Closes #12191
Changed files
The goal of the changes in the AiChatComponent.java is to have access to the chat history and to trigger another response from the LLM. It describes the logic behind the button.
The changes in ChatPromptComponent.java create the button itself the same way it is done for "retry", "submit" or "cancel".
Steps to test
This button can be accessed by going to the "AI Chat" tab of a document in an opened library, next to the "submit" button. When sending a prompt to the model, you can click on this button to resend the same message and triggering the LLM to generate another answer to the same prompt. However the previous answer is deleted from the history.
Here is an example of the usage of this button :
First answer generated :

Regenerated answer :

Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)