Draft
Conversation
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SnaveSutit
force-pushed
the
fix/api
branch
3 times, most recently
from
b4ba48e to
f8aded0
Compare
Contributor
Author
|
This has a little more work needed before it's ready. I will probably remove a few more classes from the global scope. |
Contributor
Author
|
This PR requires #3367 to be merged first! |
- Renamed `convert_types.js` -> `generate_types.js`. - Converted `generate_types.js` to TypeScript. - Added `--watch` argument to `generate-types`. - Added support for Regex to the `excluded` list in `type_config.json`.
A list of files to keep, but not transform.
…ockbench` This doesn't change any functionality, but it fixes all of the type merging issues we were having with the global `Blockbench` object without causing order of operation issues with the `global.ts` module.
Any modules that couldn't directly import `ModelProject` instead reference `Blockbench.ModelProject`.
Users making custom `format_pages` now get the correct typing 🎉
SnaveSutit
changed the title
Blockbench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires #3367 to be merged first!
🚧 WIP