Add detector/run-number changed hook #647
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
4 times, most recently
from
ac9b61e to
a3b5bed
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
a3b5bed to
2b339eb
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
2b339eb to
569691c
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
2 times, most recently
from
d7022f3 to
d7a06b9
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
2 times, most recently
from
4952319 to
fd4da91
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
4bb20d0 to
c0ba072
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
c0ba072 to
da1253a
Compare
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
e7f99b6 to
29b70e7
Compare
added 15 commits
September 3, 2025 18:00
baltzell
force-pushed
the
iss59-dch-redux-dc2-redux
branch
from
29b70e7 to
b6507a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support using real run numbers for simulation.
Includes DC2 support. Otherwise the same as #422
Same as #346. Closes #59.
Added abstract method detectorChanged(int run) to ReconstructionEngine, which is called automatically when the run number changes.
Moved every engine's geometry initialization from init or elsewhere to detectorChanged.
Changed the name of ReconstructionEngine's abstract event-processing method from processDataEvent to procesDataEventUser, and filterEvent to processDataEvent, such that all external uses of processDataEvent still do the right thing.
And removed EC's run number check per Cole.