Decoder speedups #784
Merged
Decoder speedups #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltzell
requested review from
raffaelladevita,
zieglerv,
ajhobart and
silvianic
as code owners
baltzell
force-pushed
the
speedups
branch
3 times, most recently
from
933faac to
e1734b3
Compare
|
getting consistently ~40% faster on ifarm/cache, github actions, and lappi |
raffaelladevita
previously requested changes
Aug 21, 2025
common-tools/clas-detector/src/main/java/org/jlab/detector/swaps/SwapTable.java
Outdated
Show resolved
Hide resolved
raffaelladevita
previously approved these changes
Sep 4, 2025
|
See #815, the difference comes from a CCDB conflict for run 809, with LTCC and helicity sharing crate/slot 19/19. |
|
As it turns out, LTCC winning over helicity is correct for 809 (now, with first match in the arbitrarily ordered list winning, instead of last as previously), and the helicity FADC reading in the KPP test were always bogus. Correct? |
|
And the extra event disappears after only the CCDB changes (CI jobs won't show it until they pickup the weekly CCDB sqlite snapshot). |
raffaelladevita
previously approved these changes
Sep 13, 2025
raffaelladevita
approved these changes
Sep 13, 2025
c-dilks
pushed a commit
that referenced
this pull request
Sep 15, 2025
* add access by hash * use hash-based access in decoding * remove clas6 detectors * add docs * only if necessary * break loop upon first c/s/c-detector match * use table-name-only initializer * use DetectorType instead of String, preload tables once * remove clas6 detectors * change hash accessor names (workaround long->int... precedence) * 10k events per decoder test job * add a static for speed * speedup swap table initialization * use default (static) generator * more less hashing * speedup initialization * optimize swap table initialization * cleanup * more comments * check CCDB tanslation tables for crate/slot/channel conflicts * add more performant accessors and use them in decoding * remove cp, use cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a dedicated CI test first ...