Skip to content

Clear DateTimePicker selection on month navigation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesssullivan merged 1 commit into from
May 1, 2026
Merged

Clear DateTimePicker selection on month navigation #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/DateTimePicker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,21 @@
onMonthChange?.(formatDate(start), formatDate(end));
};

const clearDateTimeSelection = () => {
selectedDate = undefined;
selectedTime = undefined;
};
Comment on lines +98 to +101
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 No test coverage for the new clearing behavior

The test file (src/tests/components/date-time-picker.test.ts) tests pure calendar/date helpers but has no test verifying that month navigation clears the selection. A future refactor could silently drop the clearDateTimeSelection() call from prevMonth/nextMonth without any test failing. Consider adding a test that exercises the navigation functions and asserts selectedDate and selectedTime become undefined.


// Navigate months
const prevMonth = () => {
currentMonth = new Date(currentMonth.getFullYear(), currentMonth.getMonth() - 1, 1);
clearDateTimeSelection();
emitMonthRange(currentMonth);
};

const nextMonth = () => {
currentMonth = new Date(currentMonth.getFullYear(), currentMonth.getMonth() + 1, 1);
clearDateTimeSelection();
emitMonthRange(currentMonth);
};

Expand Down
Loading