Fix incorrect scrolling behavior in tmux #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JediTerm was incorrectly handling cursor movement when the cursor was located outside the active scrolling region (e.g. updating a status bar). If the cursor was below the scroll region, operations like newlines would trigger a scroll of the main content area, causing visual corruption. This change ensures scrolling only occurs when the cursor is strictly at the bottom edge of the defined scrolling region. Also fixes DSR (Device Status Report) to respect Origin Mode by reporting coordinates relative to the scrolling region instead of absolute screen coordinates. Fixes JetBrains#148. Related to https://youtrack.jetbrains.com/issue/IJPL-102697/JediTerm-mis-render-prompt-cursor-location-when-inside-tmux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JediTerm was incorrectly handling cursor movement when the cursor was located outside the active scrolling region (e.g. updating a status bar). If the cursor was below the scroll region, operations like newlines would trigger a scroll of the main content area, causing visual corruption.
This change ensures scrolling only occurs when the cursor is strictly at the bottom edge of the defined scrolling region.
Also fixes DSR (Device Status Report) to respect Origin Mode by reporting coordinates relative to the scrolling region instead of absolute screen coordinates.
Fixes #148.
Related to https://youtrack.jetbrains.com/issue/IJPL-102697/JediTerm-mis-render-prompt-cursor-location-when-inside-tmux.
Before:
After:
