feat: Settings: Add Environment section with default clone directory #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @JetpackDuba , can i have a review ? Want to know if I could improve something here (really like gitnuro and want to improve it) |
|
Hello! Yes, sorry. I have been a bit busy with my job and some health issues. Probably in a week or so I will be back to normal and review everything pending. Sorry again for the delay. |
JetpackDuba
requested changes
Jun 25, 2025
src/main/kotlin/com/jetpackduba/gitnuro/ui/dialogs/CloneDialog.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetpackduba/gitnuro/ui/dialogs/settings/SettingsDialog.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetpackduba/gitnuro/ui/dialogs/settings/SettingsDialog.kt
Show resolved
Hide resolved
Anusorn1997
approved these changes
Aug 9, 2025
Anusorn1997
approved these changes
Aug 9, 2025
|
Sorry, I forgot about this PR :/ I've made the respective changes, so have another look @JetpackDuba . |
Repository owner
deleted a comment from
Anusorn1997
Aug 9, 2025
Repository owner
deleted a comment from
Anusorn1997
Aug 9, 2025
|
Hello! |
# Conflicts: # src/main/composeResources/values/strings.xml
|
Hi! Done :) Feel free to merge |
|
I've squashed it into a single commit since the other commits were small and I didn't want to have to merges from main to the branch displayed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on request #261 , a new setting (with section "Environment" ) is introduced.
When the clone repository dialog is opened, the settings is read.
The clonerepository dialog contains a checkbox to allow overwriting the setting from the dialog.
Since this is my first touch with Kotlin, please always ELI5 :)