fix: Fix build in environments without Python 2 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by: prometheus/prometheus#8733 I successfully built this commit using the docker images: - node:16.13.2-stretch - node:16.13.2-buster - node:16.13.2-bullseye - node:16.13.2-alpine3.14 - node:16.13.2-alpine3.15 - node:17.3.1-stretch - node:17.3.1-buster - node:17.3.1-bullseye - node:17.3.1-alpine3.14 - node:17.3.1-alpine3.15 Note that building in any `node:17` image requires `NODE_OPTIONS=--openssl-legacy-provider` during `npm install`.
|
Thanks for the hint. I just stumbled upon the very same issue. However, with this merge request alone the SASS themes do not compile properly, at least on my end. This seems to be due to a mixup of SCSS and SASS syntaxes in the themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by: prometheus/prometheus#8733
I successfully built this commit using the docker images:
Note that building in any
node:17image requiresNODE_OPTIONS=--openssl-legacy-providerduringnpm install.