Skip to content

Conversation

@area
Copy link
Member

@area area commented Sep 22, 2021

Closes #991 (when it's done).

Currently, this just has some failing tests!

@kronosapiens
Copy link
Contributor

kronosapiens commented Sep 22, 2021

Currently, I do not believe we can support the spec of "extensions for other colonies", as we cannot determine from an extension address which colony it is installed in. Not true, we can query the extension for it's claimed colony.

Once #971 is merged, however, we can support this, as we can do a lookup from extension address to colony. I would suggest we merge the feature as-is and update it once #971 is complete.

@area area force-pushed the feat/no-extension-reputation branch from 9df1fc6 to 059abe4 Compare September 23, 2021 16:31
@area area force-pushed the feat/no-extension-reputation branch from 059abe4 to cf8ec37 Compare September 23, 2021 16:37
kronosapiens
kronosapiens previously approved these changes Sep 23, 2021
@area
Copy link
Member Author

area commented Sep 24, 2021

Using superpowers to merge this. If you have a problem with my last commit @kronosapiens then bring it up with me, but in another PR 😛

@area area merged commit b4cdbde into develop Sep 24, 2021
@area area deleted the feat/no-extension-reputation branch September 24, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent extensions being awarded reputation, taking network fee

3 participants