Support different sites in Sharepoint, requires full site URL when fetching digest #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching digest
Most endpoints in the SPOL auth class appear to need just the Sharepoint FQDN (e.g. mycompany.sharepoint.com)
However for the digest to be valid when working with sites (e.g. mycompany.sharepoint.com/sites/MySite), the digest needs to be fetched for the correct site.
With these changes, when working with sites, connect using e.g.
```
sharepy.connect("https://mycompany.sharepoint.com/sites/MySite")
```
Although the code is robust to with/without "https?://" and with/without trailing "/"
|
This PR fixed an issue I was having as well. Any interest in adding this work @JonathanHolvey? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most endpoints in the SPOL auth class appear to need just the Sharepoint FQDN (e.g.
mycompany.sharepoint.com) However for the digest to be valid when working with sites (e.g.mycompany.sharepoint.com/sites/MySite), the digest needs to be fetched for the correct site.With these changes, when working with sites, connect using e.g.
Although the code is robust to with/without
https?://and with/without trailing/.Without these changes, when trying to upload a file to a Sharepoint site (e.g.
mycompany.sharepoint.com/sites/MySite) I get the error: